• blaue_Fledermaus@mstdn.io
      link
      fedilink
      arrow-up
      8
      ·
      2 hours ago

      Static types are great, but not exactly what would have helped here, any decent language or at least a linter should catch the use of a not declared identifier.

        • Strykker@programming.dev
          link
          fedilink
          arrow-up
          2
          arrow-down
          2
          ·
          38 minutes ago

          It’s python, just use type hinting already and your linter will catch that.

          Also some winters can look at the use of food and see the type being passed in.

          • Ephera@lemmy.ml
            link
            fedilink
            arrow-up
            3
            ·
            26 minutes ago

            Autocorrect got you pretty bad, there.

            I was very confused, why we’re suddenly talking about rationing food during winter. 🙃

          • FizzyOrange@programming.dev
            link
            fedilink
            arrow-up
            2
            ·
            17 minutes ago

            Yes you can use static type hinting and the static type checker (Mypy or Pyright) will catch that. Linters (Pylint) won’t.

        • ripcord@lemmy.world
          link
          fedilink
          arrow-up
          1
          arrow-down
          2
          ·
          46 minutes ago

          Not with an example that simple and poor, no.

          If you have done the minimum and at least set a type hint, or if your ide is smart enough to check what calls the function and what it passes, then it’ll be flagged.

          • Ephera@lemmy.ml
            link
            fedilink
            arrow-up
            2
            ·
            22 minutes ago

            How would you make it non-awful, without specifying static types?

            I guess, a unit test would catch it, but needing 100% test coverage to catch typos isn’t exactly great…

            • BrianTheeBiscuiteer@lemmy.world
              link
              fedilink
              arrow-up
              1
              ·
              edit-2
              3 minutes ago

              What’s the purpose of foo? Why an ambiguous single character variable? What if the property was there but the value was null? Why not use (assuming JS) optional chaining?

              I’d approach it more like this:

              function getWhatevrProp(userData) (
                const default = { whatevr: "n/a" };
              
                return { ...default, ...userData }.whatevr;
              }
              

              Sorry, read too fast the first time. It’s more likely Python. I also don’t know Python well enough to give recommendations on that.

  • Feathercrown@lemmy.world
    link
    fedilink
    English
    arrow-up
    4
    ·
    3 hours ago

    I spent like 3 hours yesterday deduplicating two functions that were hundreds of lines long and nearly identical. I should probably learn how to use that git command that can diff two files on disk. Luckily I actually enjoy cleaning up code sometimes.