• Luci
    link
    fedilink
    English
    arrow-up
    24
    ·
    5 months ago

    Like the first time it came up, politely with a complete PR, and it was just shut down?

    • macniel@feddit.org
      link
      fedilink
      arrow-up
      9
      arrow-down
      1
      ·
      edit-2
      5 months ago

      you mean this one https://github.com/SerenityOS/serenity/pull/6814 three years ago? yeah that was not the nicest reaction. Bridgading in that old thread and the thread about the accepted and merged PR was not nicest reaction as well.

      Also the merged PR was way more of substance and didn’t just replace he with they in that one line whereas there were several occasion where that issue occured in the same file. If the original one would have been merged, the documentation file would be inconsistent.

      • GreyEyedGhost
        link
        fedilink
        arrow-up
        17
        ·
        5 months ago

        As someone who hasn’t bothered to read any of the detail about this whole mess until just now, the comments from three years ago were all relatively civil, even if the response by the developer was dismissive. That this was corrected within 6 weeks and people are still talking about it is pretty impressive, though. Looks like people are trying to make enemies, not converts.

        • macniel@feddit.org
          link
          fedilink
          arrow-up
          5
          ·
          5 months ago

          Looks like people are trying to make enemies, not converts.

          Yeah and it’s fecking sad, no even embarrassing.