Match up Time
LAK LAK - TOR TOR 08:00PM EDT

 

I am open source! Report issues, contribute, and fund me on my GitHub page!

  • Aawr
    link
    fedilink
    arrow-up
    1
    ·
    11 months ago

    I don’t think I’m running the latest image, haven’t had a chance to update it and pull the latest, I was going to make sure I was on the latest before I bring it up

    • Dandroid@dandroid.app
      link
      fedilink
      arrow-up
      2
      ·
      11 months ago

      I haven’t made an update to that area in the lastest image.

      I heavily rewrote the logic last weekend to optimize what was being downloaded from the NHL API, and I broke a few things and just haven’t gotten around to fixing it.

      Before I was downloading all the data for every game every 30 seconds, then discarding the games that weren’t relevant right now. But I updated it so it doesn’t download anything not from your selected teams and for games that are more than an hour away from starting. This was a much needed optimization, but it introduced several bugs, including this one.

      I need to write more unit tests to catch these things! 😭

    • Dandroid@dandroid.app
      link
      fedilink
      arrow-up
      2
      ·
      11 months ago

      So I actually gave this some more thought. I think having a daily thread even when all the games are full posts rather than comments would be nice in the case of [email protected], so during the playoffs you can see an overview of all of the games. However, it’s still useless in your case. I think the way I’m going to do it is if there is 2 or more games in a day, the daily thread gets made. I am testing the change today and hopefully will push it out before the Leafs game. I think your most recent daily thread will get stuck as featured, so you might need to unfeature it manually.

      • Aawr
        link
        fedilink
        arrow-up
        2
        ·
        11 months ago

        That seems like a great idea. It will still have niche uses for a single team that way. I.e. split squad preseason game days