Did @[email protected] or @[email protected] put together a draft FEP that successfully merges 7888, 400e, and @[email protected]’s conversation containers? I remember reading it last week, and wonder if it’s the one true FEP that will render the others obsolete.

  • julian@community.nodebb.orgOP
    0·
    2 months ago

    @[email protected] Thanks for sharing this. I’m confused by these two sentences:

    Collection type SHOULD be Context. … Add.target MUST be a partial representation of the collection. Thus, if type of the collection is Context, any Add activity modifying that collection can be identified by Add.target.type.

    My context collection is of type OrderedCollection. I don’t believe Context is one of the AS2 core types.

    I don’t see any reference to collection type being Context in @[email protected]’s original document.

    • Mike Macgirvin 🖥️@fediversity.site
      1·
      2 months ago

      That wasn’t in my original doco and I’m not using it currently. I’ll need to see what problem is solved by having Context before I offer an opinion.

      I recall @[email protected] took issue with the fact that ‘context’ and ‘target’ are the same object and he felt this was duplicitous. There’s also a bit of an issue that a “partial object” (defined in FEP-400e) isn’t really defined anywhere in the base specs either - and perhaps using Context will help resolve that.

      Since it’s a SHOULD, my original implementation is arguably compliant with the FEP without it.

      • silverpill@mitra.social
        1·
        2 months ago

        @mikedev @trwnh @julian

        Context helps with identifying the target. When I receive an Add activity, I need to know what collection is being modified. Is it a featured collection, a context, or something else?

        One solution is to keep an index of all known collections and search through it every time Add is received.
        Another solution would require cooperation from producers, but I think it is a bit cleaner: embed partial representation of a target and use specific type there, like Context, instead of Collection. Then, as a consumer, I can simply check target.type instead of searching for target.id in my collection index.