• ImplyingImplications
    link
    fedilink
    arrow-up
    62
    arrow-down
    5
    ·
    2 months ago

    There’s a string stating that the code should not be passed or the employee will be fired. I’d assume this was a test to see if an employee meant to be doing code review was actually doing them. Spoiler, they were not, as OP said they found this in production code.

    • xmunk@sh.itjust.works
      link
      fedilink
      arrow-up
      17
      arrow-down
      4
      ·
      2 months ago

      I’d go a step further and I suspect it’s a peppering string (i.e. fixed string you add to hashes to defeat rainbow tables). I’d really hope it isn’t as you mentioned because gosh that sounds like a toxic workplace if someone is just leaving landmines around purely to get someone fired.

      • skulblaka@startrek.website
        link
        fedilink
        arrow-up
        19
        arrow-down
        1
        ·
        2 months ago

        More like, you know damn well that Jim keeps passing code reviews without reading a line in them, he’s been talked to, still does it, and you need something actionable to prove it so that you can get someone’s ass in his chair who does their job.

        • jcg@halubilo.social
          link
          fedilink
          arrow-up
          11
          ·
          2 months ago

          From the stories I’ve heard from corporate software employees, this does sound like exactly the kind of thing you gotta do to show some manager the guy is buddy-buddy with that they’re actually not doing their job. And even then they didn’t listen.

        • xmunk@sh.itjust.works
          link
          fedilink
          arrow-up
          3
          arrow-down
          2
          ·
          2 months ago

          No, I don’t think so - it’s just a dick move to go out of your way to sabotage someone. If they’re fucking up just visit their existing mistakes - don’t waste time contriving new ones.

          • Reddfugee42@lemmy.world
            link
            fedilink
            arrow-up
            1
            ·
            2 months ago

            So when TSA sends fake guns and bombs through luggage, it’s not qa, it’s just a dick move to sabotage them?